GitMurf / obsidian-drag-and-drop-blocks

Drag and Drop blocks to move, copy and create block references.
81 stars 6 forks source link

suggestion: use grey for drag handle color #26

Open jsmorabito opened 2 years ago

jsmorabito commented 2 years ago

I noticed that the drag handle in Remnote and the menu icon (next to bulleted lists) in Dynalist are grey and I think that would be a good default

image

image

text-faint is what the fold icon is using in Obsidian so I think that'd be good to use image

GitMurf commented 2 years ago

Thanks for the suggestion. The problem is light vs dark mode and different themes. I use one of the main - - accent color variables to make sure it fits in line with whatever theme is being used.

Either way I plan to make this a setting soon to easily change. Also it is setup so anyone can change via CSS snippet.

jsmorabito commented 2 years ago

Got it! Is this the right way to do it as a snippet? I mean it works fine but I heard it's better to avoid !important if possible :)

#block-ref-hover.show { color: #999999 !important; }

GitMurf commented 2 years ago

@jsmorabito yes it’s best not to use !important… in fact I just made a post about it in the obsidian discord haha. It’s a pet peeve of mine.

Instead of using !important you just need to make your selector more specific. So just add div in front. Try this and it should work:

div#block-ref-hover.show { color: #999999 }

Please let me know if this works.

jsmorabito commented 2 years ago

@jsmorabito yes it’s best not to use !important… in fact I just made a post about it in the obsidian discord haha. It’s a pet peeve of mine.

Instead of using !important you just need to make your selector more specific. So just add div in front. Try this and it should work:

div#block-ref-hover.show { color: #999999 }

Please let me know if this works.

works, thank you!! just saw the post too, thanks for that write up 💪

jsmorabito commented 2 years ago

oh do you want to close this issue or keep it open, if you're going to add this as an option for users I can leave it open as a reminder

GitMurf commented 2 years ago

Thanks. Yes let’s leave open as a reminder to add the setting.