GiveToken / GiftBox

Repository for Sizzle
0 stars 0 forks source link

[1024] [1029] Fixes back button when interest dialog is open #1065

Closed shreydesai closed 8 years ago

shreydesai commented 8 years ago

1024 - The back button is now disabled when the interest dialog is open

1029 - This problem was caused by the back button not working when the interest dialog was open, but this should not be a concern anymore since the back button will be disabled altogether

wogsland commented 8 years ago

This work pretty well, although I couldn't test the location page's back button because of the newly discovered #1066.

One thing I would add with regard to #1024: Can you grey out the BACK button like the rest of the screen to signal to the user that it's unavailable?

shreydesai commented 8 years ago

I fixed the additional request to #1024.

It looks like the jQuery selectors for Polymer elements tend to differ between iOS/OSX, but it's all fine now. I also remembered to run polybuild.sh, but you can double check. I took a look at #1066 and it definitely seems like a problem. I'll try working on it so that the BACK button appears and then maybe you can re-evaluate this pull request.

wogsland commented 8 years ago

Back button is still in the foreground on the company page (the one with images).

wogsland commented 8 years ago

Click "Company Information" or the company images above to get to what I'm calling the company page:

simulator screen shot jun 10 2016 11 34 34 am

shreydesai commented 8 years ago

New changes:

Issue #1066 is still rampant, so I will fix that next.

wogsland commented 8 years ago

Lookin' good!