search

GiveToken / GiftBox

Repository for Sizzle
0 stars 0 forks source link

Feature/890 city images endpoint #905

Closed rnc505 closed 8 years ago

rnc505 commented 8 years ago

Closes #890

wogsland commented 8 years ago

1) Can you remove the changes that get rid of the old image_file field. These changes break things until the frontend uses this new ajax endpoint 2) There were 2 failures:

1) Sizzle\Tests\Ajax\City\GetImagesTest::testRequest
Failed asserting that 0 matches expected 4.

/Library/WebServer/Documents/GiftBox/src/tests/Ajax/City/GetImagesTest.php:53

2) Sizzle\Tests\Ajax\City\GetImagesTest::testFailNoCookie
Failed asserting that 0 matches expected 4.

/Library/WebServer/Documents/GiftBox/src/tests/Ajax/City/GetImagesTest.php:133
rnc505 commented 8 years ago

Fixed comments

rnc505 commented 8 years ago

Ready for merge?