Glitchfinder / EnderSpawn

A bukkit plugin that manages Enderdragons in The End.
GNU General Public License v3.0
5 stars 3 forks source link

When loading configuration, an NPE can occur #1

Closed jgeboski closed 12 years ago

jgeboski commented 12 years ago

It looks like our server is having an issue while trying to load the configuration as of 2dd4536. Some mild investigations and it looks like there needs to be a null for getConfigurationSection() as it can return null. (https://github.com/Bukkit/Bukkit/blob/master/src/main/java/org/bukkit/configuration/MemorySection.java#L656) Additionally, if getConfigurationSection() always returns null the last kill times for players will never be loaded.

NPE:

[SEVERE] Error occurred while enabling EnderSpawn v0.1 (Is it up to date?)
java.lang.NullPointerException
        at org.enderspawn.Configuration.getPlayers(Configuration.java:142)
        at org.enderspawn.Configuration.load(Configuration.java:106)
        at org.enderspawn.EnderSpawn.onEnable(EnderSpawn.java:63)
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:217)
        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:357)
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:381)
        at org.bukkit.craftbukkit.CraftServer.loadPlugin(CraftServer.java:263)
        at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:245)
        at net.minecraft.server.MinecraftServer.i(MinecraftServer.java:296)
        at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:275)
        at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:225)
        at net.minecraft.server.DedicatedServer.init(DedicatedServer.java:140)
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:380)
        at net.minecraft.server.ThreadServerApplication.run(SourceFile:539)

Configuration:

Configuration:
  DestroyBlocks: false
  SpawnEgg: true
  SpawnPortal: false
  RespawnMinutes: 5
  EXPResetMinutes: 1320
  EXPMaxDistance: 75
  MaxDragons: 1
  EggsCanTeleport: false
LastDeath: 1344290451160
Players:
- Time: '2012-08-05 23:23:43.598'
  Player: removed
- Time: '2012-08-06 12:29:18.265'
  Player: removed
- Time: '2012-08-06 12:29:18.265'
  Player: removed
- Time: '2012-08-06 18:00:51.174'
  Player: removed
- Time: '2012-08-05 23:23:43.597'
  Player: removed
- Time: '2012-08-05 23:23:43.598'
  Player: removed
BannedPlayers: []