[Scratch] Merge from vessel-lists

bitsofbits commented 8 years ago

Do not merge. Will probably copy into a new branch to maintain a cleaner git history.

Closes #10

Adding files and reorganizing files from vessel-lists

[x] Copy relevant issues over from vessel-lists. Skipping
- 26 Better Name
- 19 Organize vessel-list repo

geowurster commented 8 years ago

@bitsofbits I think this is a pretty good MVP. We still need to address treniformis/internal.

bitsofbits commented 8 years ago

@geowurster:

API seems fine
Naming:
- I don't like the name internal very much although it seems fine to punt on that till we have a better idea what we're going to with the contents.
- I still think we'd be better off putting all three of the fishing lists (known-fishing, likely-fishing, known-or-likely-fishing) on the same level.
Should pip install . be working? It's failing for me with

    copying treniformis/internal/lists_from_web/ITU_Dec_2015_full_list.csv -> build/lib/treniformis/internal/lists_from_web
    copying treniformis/internal/lists_from_web/readme.md -> build/lib/treniformis/internal/lists_from_web
    creating ../../../../../var
    error: could not create '../../../../../var': Permission denied

That's it for now. Thanks for working on this.

geowurster commented 8 years ago

Superseded by https://github.com/GlobalFishingWatch/treniformis/pull/13.

GlobalFishingWatch / treniformis

[Scratch] Merge from vessel-lists #1