Closed redhog closed 7 years ago
@redhog: also can you update the example in README.rst
since the API it references is going away. (There's probably a lot of stuff in there that should be updated now, but at least we should do that).
for 2) I suggest bumping the version to 0.4 after merge for 3) I suggest not deleting code now, but in a separate PR.
Sounds fine. Probably even better would be to throw in a DeprecationWarning for a bit and then kill it. But we can do that later.
@redhog
Three things:
[x] Checks are failing because the relied on the old path based API. Can you fix those?
[x] There is conflict with the version file. I think I'd just leave the version number alone and we'll bump the version number when we cut the next release.
[x] If the pipeline isn't using
build_combined_fishing_list
, I suggest we just rip that out rather than fixing it. The combined fishing list is generated statically inside oftreniformis
these days, so having a function that generates it on the fly is just a way for the code to get out of sync....