GlobalPathogenAnalysisService / gpas-cli

The CLI client for GPAS SC2
Other
5 stars 2 forks source link

EC 1.1.4 with gpas-cli 0.6.0 - Error message "unauthorised for this user" appears for invalid tags #101

Open KuzminaAnna opened 1 year ago

KuzminaAnna commented 1 year ago

This is related to the issue #99 Describe the problem/error: Error message "tag(s) {'&', '()', '$'} are unauthorised for this user" appears after uploading csv file which contains invalid tags. User is not able to authorise tags which he not able to add because they are invalid.

Expected behaviour: "tag(s) {'&', '()', '$'} are invalid for this organisation".

Steps to Reproduce:

Actual response: { "validation": { "status": "failure", "errors": [ { "error": "tag(s) {'$', '&', '()'} are unauthorised for this user" } ] }} test.csv

bede commented 1 year ago

Thanks Anna, I agree that notions of validity and authorisation have been conflated here.

I am happy to restore previous behaviour in 0.8.0, but I took from our conversation that we should await clarity over tag implementation before making further changes. Do you agree? On this basis I'm marking this as blocked for now.