GlobalPathogenAnalysisService / gpas-cli

The CLI client for GPAS SC2
Other
5 stars 2 forks source link

EC 1.1.4: "sample_name must be unique" error message is not returned to the user if metadata contains invalid platform #95

Closed KuzminaAnna closed 1 year ago

KuzminaAnna commented 1 year ago

Describe the problem/error: If a metadata contains non-unique sample names in-addition to invalid instrument_platform values, "sample_name must be unique" error message is not returned to the user. Instead only error message about invalid instrument_platform is returned to the user. Expected behaviour: "sample_name must be unique" error message should be returned to the user in-addition to other invalid errors

Steps to Reproduce:

System Identification: DEV Reproducible? Yes If multiple areas are impacted list areas: Electron client 1.1.4 all platforms. If compatibility/interoperability is impacted list products (e.g.): Gpas Portals. illumina-fastq-upload_sample_name_same_invalid_platfrom.csv.zip Screen Shot 2022-11-15 at 9 04 14 PM

bede commented 1 year ago

This is expected behaviour – schema selection is a necessary pre-validation step prior to the main, lazily evaluated validation process. However, I have made it trigger a ValidationError to avoid confusion.