search

GlobeTownDevs / api

0 stars 1 forks source link

Merged fix for async functions and infographic #22

Closed tbtommyb closed 8 years ago

tbtommyb commented 8 years ago

I've tested this and it all seems to be working ok. The only think is that closing the visualisation takes a while because it starts a whole new request again rather than just closing the overlay so I'll look at that now.

njsfield commented 8 years ago

Ah just seen you've made a working pull too! I tried to pull in your changes to mine and add some extra callback functionality but if you're sorting the visualisation issues I'll close my pull request now.

marisid commented 8 years ago

Hey, good job there! I just tried to checkout your branch to see how it looks like, using the hack from the terminal to make the TextRazor requests but couldn't do it. Can't wait to see it tomorrow! Also, I added a small edit in the css to fix a bug on desktop view (see pull request #24).

lucymonie commented 8 years ago

Hey guys, I can't get my Chrome to turn off the security settings so I can't check these and merge them either. I have done some code for the google pie chart in case you want to check it out as an option: the code is here and the viz is here.

lucymonie commented 8 years ago

Marina, I merged yours - I figured it was small enough that it was probably okay to do it!

marisid commented 8 years ago

Thanks @lucymonie! Yeah, I couldn't turn off security settings for Chrome either. I really like your pie chart!! If we have time tomorrow, we can add as a second infographic.