search

Gnurou / v4l2r

Rust bindings for V4L2
MIT License
21 stars 10 forks source link

Support for VIDIOC_S_CTRL? #12

Open mfreeborn opened 1 year ago

mfreeborn commented 1 year ago

I'm trying to implement an H264 encoder in Rust, which takes YUV420 format frames from a Raspberry Pi camera and converts it to H264. Essentially I'm trying to replicate this functionality: https://github.com/raspberrypi/libcamera-apps/blob/eca5a3c5eada4b3caa52a7ed33eafd4eb0be78c7/encoder/h264_encoder.cpp#L41

Have I interpreted the v4l2r::ioctl module correctly in that it doesn't support VIDIOC_S_CTRL to do things such as set the H264 profile and level etc?

I otherwise have a working pipeline based on the v4l2r::encoder::Encoder which is really great.

Gnurou commented 1 year ago

Hi! Right, support for controls is missing at the moment. I'll try to review your PR shortly.

Gnurou commented 10 months ago

Now that support for VIDIOC_S_EXT_CTRLS is merged, can we close this issue?