GoMexSI / gomexsi-web

Explore Species Interactions in Gulf of Mexico with the GoMexSI webapp
http://gomexsi.tamucc.edu
3 stars 2 forks source link

Spatial query page returns results that are outside the spatial search box. #12

Closed jhpoelen closed 11 years ago

jhpoelen commented 11 years ago

Steps to reproduce:

  1. login to gomexsi, goto 'Query Database', then 'Spatial Query'
  2. enter 'Ariopsis felis' into the search box, check 'Prey' checkbox and select move the search box away from the gulf of mexico
  3. in results, confirm that locations are within the provided search area.

Expected results:

Only results within the search area are listed. In this case, no observations are expected, because the search box fell outside of the area covered by our current datasets.

Actual results:

All observations of Ariopsis felis are shown (currently 368 items) and locations related to these items do not always fall in the search area.

jsimons9 commented 11 years ago

Hi Jorrit,

I was doing some searching and checking on the website, and did query, then was checking the map. One of the maps that came up obviously has an incorrect coordinate. With contributed data we will need to screen it, I guess through plotting it, or an electronic screen, at least for the big picture. I am assuming that the ID of that record is obtainable somehow.

Thanks,

Jim

PS I am hoping to have the king mackerel data to you soon. BTW, what data sets are currently in the test database??

From: jhpoelen [mailto:notifications@github.com] Sent: Thursday, April 18, 2013 12:51 PM To: jhpoelen/gomexsi Subject: [gomexsi] Spatial query page returns results that are outside the spatial search box. (#12)

Steps to reproduce:

  1. login to gomexsi, goto 'Query Database', then 'Spatial Query'
  2. enter 'Ariopsis felis' into the search box, check 'Prey' checkbox and select move the search box away from the gulf of mexico
  3. in results, confirm that locations are within the provided search area.

Expected results:

Only results within the search area are listed. In this case, no observations are expected, because the search box fell outside of the area covered by our current datasets.

Actual results:

All observations of Ariopsis felis are shown (currently 368 items) and locations related to these items do not always fall in the search area.

— Reply to this email directly or view it on GitHubhttps://github.com/jhpoelen/gomexsi/issues/12.

jhpoelen commented 11 years ago

Hi Jim,

Thanks for your response. The issue you are describing sounds different than the issue described here. Please open a new issue and describe how we can reproduce this issue in steps formulated just like in issue #12 - using the format: steps to reproduce, expected result and actual result.

Contact me if you have any questions about this. thx, -jorrit

jsimons9 commented 11 years ago

OK,

Steps to reproduce:

  1. login to gomexsi, goto 'Query Database', then 'Taxonomic Query'
  2. enter 'Ariopsis felis' into the search box, check 'Prey' checkbox and then submit query.
  3. in results, click on the map button for the first set of data returned.

Expected results: Data point should fall somewhere in the Gulf of Mexico.

Actual results: Data point is west of St. Joseph, Kansas and east of Prairie Dog State Park. ☺

From: jhpoelen [mailto:notifications@github.com] Sent: Thursday, April 18, 2013 3:41 PM To: jhpoelen/gomexsi Cc: Simons, James Subject: Re: [gomexsi] Spatial query page returns results that are outside the spatial search box. (#12)

Hi Jim,

Thanks for your response. The issue you are describing sounds different than the issue described here. Please open a new issue and describe how we can reproduce this issue in steps formulated just like in issue #12 - using the format: steps to reproduce, expected result and actual result.

Contact me if you have any questions about this. thx, -jorrit

— Reply to this email directly or view it on GitHubhttps://github.com/jhpoelen/gomexsi/issues/12#issuecomment-16606957.

jhpoelen commented 11 years ago

Jim - thanks for providing the detailed description. This is really helpful.

Now, to complete the creation of a new issue, please goto:

http://github.com/jhpoelen/gomexi/issues

click "new issue"

and copy/ paste your description.

A new issue should now be created.

thx, -jorrit

jsimons9 commented 11 years ago

I got a message that that was not the page I was looking for.

BTW, I have another issue, too. I will do that once we have the issue thing figured out.

Jim

From: jhpoelen [mailto:notifications@github.com] Sent: Thursday, April 18, 2013 4:07 PM To: jhpoelen/gomexsi Cc: Simons, James Subject: Re: [gomexsi] Spatial query page returns results that are outside the spatial search box. (#12)

Jim - thanks for providing the detailed description. This is really helpful.

Now, to complete the creation of a new issue, please goto:

http://github.com/jhpoelen/gomexi/issues

click "new issue"

and copy/ paste your description.

A new issue should now be created.

thx, -jorrit

— Reply to this email directly or view it on GitHubhttps://github.com/jhpoelen/gomexsi/issues/12#issuecomment-16610131.

jsimons9 commented 11 years ago

OK, I typed it in and it seems to get me where I need to go.

Jim

From: jhpoelen [mailto:notifications@github.com] Sent: Thursday, April 18, 2013 4:07 PM To: jhpoelen/gomexsi Cc: Simons, James Subject: Re: [gomexsi] Spatial query page returns results that are outside the spatial search box. (#12)

Jim - thanks for providing the detailed description. This is really helpful.

Now, to complete the creation of a new issue, please goto:

http://github.com/jhpoelen/gomexi/issues

click "new issue"

and copy/ paste your description.

A new issue should now be created.

thx, -jorrit

— Reply to this email directly or view it on GitHubhttps://github.com/jhpoelen/gomexsi/issues/12#issuecomment-16610131.

reedhewitt commented 11 years ago

In regards to the original issue, the spatial query form submits four boundary parameters: boundNorth, boundEast, boundSouth, and boundWest. (Obviously, the north and south are latitude and the east and west are longitude.) The request handler or the REST API needs to limit the results based on these boundary values.

I've changed the assignment of this issue to Michael, since I don't think there is anything to change on the front end.

jhpoelen commented 11 years ago

I am working on implementing this functionality in the rest service before Michael connect it.

jhpoelen commented 11 years ago

I've implemented REST API features to restrict observations to spatial search box. Michael / Reed - please review my descriptions at https://github.com/jhpoelen/eol-globi-data/wiki/Rest , especially the section on spatial searches. Let me know if there's anything else you guys need to hook this up to gomexsi website.

MikeCasavecchia commented 11 years ago

This should now be working.

@reedhewitt Can you update the code to reflect this when you have a second, thanks.