search

GoaFan77 / Enhanced4XModRepo

Repository for the latest version of the Enhanced 4X Mod.
4 stars 4 forks source link

Cannot establish embassies with minor factions #12

Closed raixdawolf closed 5 years ago

raixdawolf commented 5 years ago

When sending an envoy ship to establish an embassy with a minor faction, an error is issued indicating that this ability can only be used on friendly targets. No embassy is established and you are effectively locked out of using minor factions to your advantage.

This is likely due to something within the conditional logic regarding what targets an envoy can used the ability establish embassy on. An exception should be made specifically for minor factions, though logic may need to be included for players with certain relationships. An example of this would be from Civilization, where City States will refuse to deal with a player if they have showed aggression towards other City States in the past.

It is currently unknown if the Goodwill ability from the base game is available on embassies. A quick fix may involve allowing envoys to used this ability again.

Donos47 commented 5 years ago

This issue is fixed by commit d5e807e8007706c5f51d11dcdd9cbcfdf6cdc0f9 . The Goodwill ability needed to be replaced with the GoodwillMinorFaction ability, which can target minor faction worlds

raixdawolf commented 5 years ago

It appears to work on some worlds and not on others. Will investigate further.

GoaFan77 commented 5 years ago

@raixdawolf Please let us know. We are currently updating the mod for the new minor factions DLC. If you have pulled the latest build from github and are having issues with capturing minor factions, we will reopen this issue.

Note there is a bug with the mods original "random encounter" factions causing strange militia owned worlds to spawn. These are not minor factions but look similar, so that might explain why its not working on some worlds.

raixdawolf commented 5 years ago

@GoaFan77 I think that is all it was. Once we got it working, we figured this was the problem. Thank you and @pmaher478 for getting back on the issue.

EDIT: For others who stumble upon this issue wondering how to differentiate: minor factions will indicate they are such when hovering over as it will list minor faction bonuses. Random encounter factions as above indicated will not have any such indication in the mouse over information.