GoodDollar / GoodWeb3-Mono

mono repo with GoodDollar's web3 UI components and SDK
https://gooddollar-storybook.vercel.app
0 stars 1 forks source link

Bug: Lint-staged uses root typescript version #103

Closed L03TJ3 closed 1 year ago

L03TJ3 commented 1 year ago

Description

Lint-staged currently breaks commiting changes to sdk-v2. its called on pre-commit through husky, and it uses root tsc version tsc < 5 is not able to compile sdk-v2 any longer

Optional solutions:

Steps to reproduce

  1. enable yarn lint-staged in husky
  2. make change in sdk-v2
  3. commit
  4. see result

Verify that it is using tsc@4 from root is to install locally tsc@4 and run it on sdk-v2 package. same error output

L03TJ3 commented 1 year ago

apparently a false positive on this issue cannot replicate so closing for now