GoodDollar / GoodWeb3-Mono

mono repo with GoodDollar's web3 UI components and SDK
https://gooddollar-storybook.vercel.app
0 stars 1 forks source link

Workspaces hoisting limits #108

Closed L03TJ3 closed 10 months ago

L03TJ3 commented 10 months ago

Description

At some point in the past the decision was done to have no hoisting limits and rely on yarn to decide which versions of dependency get placed in the root node_modules. The pro's of this would be: smaller node_modules on disk-space, easier syncing of same dep versions across the packages.

The benefit of setting the nmHoistingLimits to 'workspaces' would be:

Since we also host some legacy (or barely used) packages in the mono-repo we already almost never define root package dependency so having workspaces as a limit is not that strange.

So either on of the below is a solution

L03TJ3 commented 10 months ago

@johnsmith-gooddollar @sirpy please comment on your thoughts which way to go for this

for now I have opened this PR where we use workspaces limit: https://github.com/GoodDollar/GoodWeb3-Mono/pull/109

L03TJ3 commented 10 months ago

Released