GoodDollar / GoodWeb3-Mono

mono repo with GoodDollar's web3 UI components and SDK

https://gooddollar-storybook.vercel.app

0 stars 1 forks source link

chore: use simplified local version of orbis sdk #114

Closed L03TJ3 closed 4 months ago

L03TJ3 commented 7 months ago

Description

Adding a stripped down local version orbis sdk for just getPost(s).

[x] - add orbis getPost / getPosts method
[x] - add simplified flow fetching images from ipfs
[x] - integrate fetcher into orbis cache feed
[ ] - fix syncPosts
[ ] - add proper typings

About # (link your issue here) https://github.com/GoodDollar/GoodDAPP/issues/4161

How Has This Been Tested?

Locally against the dev orbis environment for the newsfeed

L03TJ3 commented 7 months ago

@johnsmith-gooddollar @sirpy Its mostly working, except a small part which I have looked at for a bit but still not sure what is causing the issue.

Its here where we decide on the need to check more pages or finalize sync: https://github.com/GoodDollar/GoodWeb3-Mono/blob/bc539791a28de5c1dc5eb2e86b3d8282d940ae1d/packages/sdk-v2/src/sdk/newsfeed/OrbisCachedFeed.ts#L75

this check causes an infinite loop now. hasOlder is always undefined.

L03TJ3 commented 7 months ago

For now we put this on hold and first focus on trying to fix the wallet's vite PR (Which will resolve the dependency issues). If sdk-v2 happens to be still needed sooner, we can make the final fix and release it as a beta package for specifically the wallet, not altering the code for main packages.