Open L03TJ3 opened 4 months ago
certificates.db.zip
@L03TJ3 an example of data structure I want to have. use SQLite client to view it. A database view was made as an example of the query to use for pick up certificates. To add type condition you could just add AND credential = '<any of VerifiableLocationCredential | VerifiableIdentityCredential | VerifiableGenderCredential | VerifiableAgeCredential>'
@johnsmith-gooddollar @sirpy I want you guys to come to an agreement before I change anything else.
What I had was nothing more then a single table: CredentialType, json
Per type of: 'localtion', 'identity', 'age', 'gender'
imo, super simple.
I am not sure what is expected of me to implement now
@johnsmith-gooddollar @sirpy I want you guys to come to an agreement before I change anything else.
What I had was nothing more then a single table: CredentialType, json
Per type of: 'localtion', 'identity', 'age', 'gender'
imo, super simple.
I am not sure what is expected of me to implement now
@L03TJ3 please do like in the .sqlite file attached also you might need https://github.com/dfahlander/dexie-relationships
@L03TJ3 alternative solution to keep everything in a single table is https://dexie.org/docs/MultiEntry-Index so fields would be id, json, credential (array of any from [VerifiableLocationCredential | VerifiableIdentityCredential | VerifiableGenderCredential | VerifiableAgeCredential])
@L03TJ3 ^^^
@L03TJ3 why You removed story ? how you would check it ?
Because credential-storage is now finalized, this PR will be turned into the general GoodID base-branch (any updates after this comment) (to not block us on master for potential non-related bug-fixes)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
gooddollar-storybook | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 16, 2024 7:49pm |
Description
Main good-id branch. Currently statusses are:
original credential-storage pr description (Reviewed)
For the MVP of the new good-id flow we need a way to store verified credentials received from the server after completing the new flow. Verified credentials will be read from storage and displayed on the goodId card
Out of scope for this pr:
About # (link your issue here)
116
For reviewers
This is the most basic setup for the database. any additional changes related to expected credential format, or for example the wallet db interface will be done in alternative pr's accociated to specific screens / steps in the good-id flow.
After review this branch will be turned in the main good-id PR