GoodDollar / GoodWeb3-Mono

mono repo with GoodDollar's web3 UI components and SDK
https://gooddollar-storybook.vercel.app
3 stars 3 forks source link

Claimflow: pool names #182

Closed L03TJ3 closed 1 month ago

L03TJ3 commented 3 months ago

Description

Pool names can be read from the registry, and should be fetched as part of the pool-details.

About # (link your issue here)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

L03TJ3 commented 3 months ago

@sirpy I started on adding this but it is not finalized yet.

Todo's:

Should be all, the rest is already handled

sirpy commented 3 months ago

@L03TJ3 what do you mean by pool name? the pool name isnt available from the blockchain. it can be read from the subgraph or ipfs.

L03TJ3 commented 3 months ago

@sirpy I assumed projectId would be the pool-name? retrieved from factory.registry

sirpy commented 3 months ago

no thats the projectid, it can have multiple pools. each pool details is in the ipfs file but the subgraph parses it, so you can query the subgraph. in our case we can make it hard coded for now

L03TJ3 commented 1 month ago

we are not doing this right now so closing