L03TJ3 commented 1 year ago

Description

List of issues can be found issue 297

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

[x] PR title matches follow: (Feature|Bug|Chore) Task Name
[x] My code follows the style guidelines of this project
[x] I have followed all the instructions described in the initial task (check Definitions of Done)
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have added reference to a related issue in the repository
[x] I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
[ ] I have added screenshots related to my pull request (for frontend tasks)
[ ] I have pasted a gif showing the feature.
[x] @mentions of the person or team responsible for reviewing proposed changes

johnsmith-gooddollar commented 1 year ago

@L03TJ3 please link the issue this is related for

johnsmith-gooddollar commented 1 year ago

@L03TJ3

url issue fixed here: https://github.com/GoodDollar/GoodDAPP/commit/4dcae7c4f5d8d13226b8e0526ff83cc0d44a94e2 make sure goodid DEV & QA redeployed successfully
why do you need additional verifying flag ? why you pass it onto onClose ? We're sending callbacks / redirecting just after it so it means user have to be verified / failed to verify at this point but not in progress ?
fix conflicts please