GoodDollar / GoodWeb3-Mono

mono repo with GoodDollar's web3 UI components and SDK
https://gooddollar-storybook.vercel.app
1 stars 1 forks source link

Bug: 326 fix switch wc #50

Closed L03TJ3 closed 1 year ago

L03TJ3 commented 1 year ago

Description

Before onboard didn't support wallet-connect switch requests at all, and just showed a modal notifying a user to do it manually. Newer implementation uses a custom request which works for metamask, but is not supported by either GD-Wallet or ZenGo (the two we currently use the customwalletconnect for)

About # (link your issue here) https://github.com/GoodDollar/GoodProtocolUI/issues/326

How Has This Been Tested?

Tested with both GD-Wallet and ZenGo with new/old implementation.

Additional context

image

required network shown is the one user has clicked on in the network modal

L03TJ3 commented 1 year ago

@patpedrosa we can update copy if needed

L03TJ3 commented 1 year ago

Closed in favour of fix #53