search

GoodDollar / GoodWeb3-Mono

mono repo with GoodDollar's web3 UI components and SDK
https://gooddollar-storybook.vercel.app
0 stars 1 forks source link

Bug: duration.format #92

Closed L03TJ3 closed 1 year ago

L03TJ3 commented 1 year ago

Description

For some unknown reasons our implementation of moment + moment-duration-format stopped working and it no longer runs duration.format --> https://github.com/GoodDollar/GoodWeb3-Mono/blob/384ce5be08c04bc6be1ae355a1c2b7a5a9c7908e/packages/sdk-v2/src/sdk/base/hooks/useTimer.ts#L11

since its a legacy package already maybe better to use different library

Steps to reproduce

Go to dev.gooddapp and claim

Additional Context

Since it seems to locally be able to still lint the typings together, it could have to do with the recent upgrade on protocolUI to typescript@5 the legacy package is stated to be built for/around typescript@2

L03TJ3 commented 1 year ago

O thought what I tried didnt/couldnt work but in the end it did: https://github.com/GoodDollar/GoodWeb3-Mono/commit/cdf2ccf1ce867fb3d1596b19a62a8b8b32f08487

L03TJ3 commented 1 year ago

verified with QA this works on prod