fix: clarify submit button change unrelated to issue #26 so reverted to previous state

GoodGameRuler / unitrack_v3

A simplified degree planner for USYD Students.

https://www.unitrack.au

GNU General Public License v3.0

3 stars 8 forks source link

Closed shivamksharma closed 3 months ago

shivamksharma commented 5 months ago

Addressed the confusion regarding the submit button modification, which was not part of the original issue #26.
Changed the submit button back to how it was before.
This update ensures consistency with the original design and functionality.

Closes #26

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
unitrack	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 31, 2024 4:46am

GoodGameRuler commented 5 months ago

Interesting. Thank you @shivamksharma for the PR however A couple things to note.

If you think the issue specifications are vague or non-encompassing please comment on the issue itself instead of PR. However this will be noted.
I don't understand the scope for misunderstanding? Why you would change something that was not part of the specifications: i.e the issue did not request the change of the button?
Generally attempt to address all issues before requesting another review (or in this case PR).

shivamksharma commented 5 months ago

well, I didn't noticed that but now I'll take care of that and I'll fix the CSS of the date picker mui component which matches the CSS of the rest !

github-actions[bot] commented 5 months ago

Stale pull request message - 7 days till automatic close