search

GoogleChromeLabs / lighthousebot

Run Lighthouse in CI, as a web service, using Docker. Pass/Fail GH pull requests.
Apache License 2.0
2.24k stars 127 forks source link

@lighthousebot in private repos? #15

Closed schoenwaldnils closed 6 years ago

schoenwaldnils commented 6 years ago

Hi, I added @lighthousebot in a private repository. (about a week ago) But the collaboration didn't get accepted yet. Is this possible, or does this need a human to accept it? ^^

ebidel commented 6 years ago

A human. Can you send the invite again? I may have missed it.

schoenwaldnils commented 6 years ago

@ebidel done

ebidel commented 6 years ago

Ah, it's because your settings require the bot to have 2-factor enabled on the account.

schoenwaldnils commented 6 years ago

Does this mean it doesn't work the lighthousebot?

ebidel commented 6 years ago

Most likely no? I don't plan on enabling 2 factor auth on that account (it's a shared account). So if that prevents you from adding it to your repo, than it won't be able to modify PR comments.

But in general, I don't see any blockers for it not working with private repos.

If you want to run your own bot that works with your repo, feel free to set that up. This repo has everything you need :)