search

GoogleChromeLabs / lighthousebot

Run Lighthouse in CI, as a web service, using Docker. Pass/Fail GH pull requests.
Apache License 2.0
2.24k stars 127 forks source link

Public-facing URL: needed? #52

Open helloguille opened 5 years ago

helloguille commented 5 years ago

Does this work with a localhost:XX-type URL?

The example shows https://staging.example.com, which looks to me like a public URL.

It might be a good idea to clarify this in the doc. I can contribute with the doc change if that's the case.

manniL commented 5 years ago

It is necessary except when you running your own API which has access to the "local" website (e.g. two servers that "know each other").

ebidel commented 5 years ago

Can you clarify the question?

On Mon, Feb 25, 2019, 7:12 AM Alexander Lichter notifications@github.com wrote:

It is necessary except when you running your own API which has access to the "local" website (e.g. two servers that "know each other").

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GoogleChromeLabs/lighthousebot/issues/52#issuecomment-467048018, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOigMugnZoE8DG0_hIeTug1LrKnW51lks5vQ_1SgaJpZM4aW0zz .

manniL commented 5 years ago

@ebidel I interpreted it as: "Can I test local pages that are not exposed to the WWW with lighthousebot."

helloguille commented 5 years ago

Yes, this is what I meant!

I was under the impression that it depended on an external service, and I wanted to integrate this in my CI build, so I needed to use a private URL.

Maybe it would be nice to clarify this in the README.

ebidel commented 5 years ago

For that case, I'd just run the lighthouse CLI or NPM module against your local app.

You could use ngrok to expose a local server...

clxmstaab commented 4 years ago

related question: in case my website is public available but behind a http-basic auth would it be possible to pass a auth/pw combination to the bot?