GoogleChromeLabs / lighthousebot

Run Lighthouse in CI, as a web service, using Docker. Pass/Fail GH pull requests.
Apache License 2.0
2.24k stars 127 forks source link

add CircleCI support #67

Closed erezrokah closed 5 years ago

erezrokah commented 5 years ago

Fixes #16

See pr here https://github.com/erezrokah/gatsby-netlify-cms-aws/pull/10

I'm still missing the github status updates, but I'm assuming it is due to this: image

(Still waiting for the bot response)

You can test it by installing directly from my branch:

yarn add --dev "https://github.com/erezrokah/lighthousebot#add_circle_ci_support"

Also I think there is a bug in the Travis support. TRAVIS_PULL_REQUEST_SLUG should be TRAVIS_REPO_SLUG (https://docs.travis-ci.com/user/environment-variables/). I think in case of forks TRAVIS_PULL_REQUEST_SLUG will contain the information of the fork, where you actually want to update the current repo status (I'm not sure since I don't use Travis).

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

erezrokah commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.