search

GoogleChromeLabs / lighthousebot

Run Lighthouse in CI, as a web service, using Docker. Pass/Fail GH pull requests.
Apache License 2.0
2.24k stars 127 forks source link

add CircleCI support #68

Open erezrokah opened 5 years ago

erezrokah commented 5 years ago

Fixes #16

You can test it by installing directly from my branch:

yarn add --dev "https://github.com/erezrokah/lighthousebot#add_circle_ci_support"

Also I think there is a bug in the Travis support. TRAVIS_PULL_REQUEST_SLUG should be TRAVIS_REPO_SLUG (https://docs.travis-ci.com/user/environment-variables/). I think in case of forks TRAVIS_PULL_REQUEST_SLUG will contain the information of the fork, where you actually want to update the current repo status (I'm not sure since I don't use Travis).

erezrokah commented 4 years ago

Is there anything missing on my end to get this PR merged?

fernandopasik commented 4 years ago

@addyosmani please could you help us with this one?