GoogleChromeLabs / lighthousebot

Run Lighthouse in CI, as a web service, using Docker. Pass/Fail GH pull requests.
Apache License 2.0
2.24k stars 127 forks source link

fix dockerfile #84

Open kminehart opened 4 years ago

kminehart commented 4 years ago

Building the docker image at the moment results in 2 problems:

  1. Missing wget
Step 4/19 : RUN wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add -     && sh -c 'echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list'     && apt-get update     && apt-get install -y google-chrome-unstable --no-install-recommends     && rm -rf /var/lib/apt/lists/*     && rm -rf /src/*.deb
 ---> Running in e1277d4915b0
/bin/sh: 1: wget: not found
  1. missing gnupg
gnupg, gnupg2 and gnupg1 do not seem to be installed, but one of them is required for this operation

So I installed them both and it seems to be working:

Step 17/19 : ENV CI=true
 ---> Running in 9b5cf80f2976
Removing intermediate container 9b5cf80f2976
 ---> ce4ba8d415fa
Step 18/19 : EXPOSE 8080
 ---> Running in 65481787df9d
Removing intermediate container 65481787df9d
 ---> 6f1602c1dbde
Step 19/19 : ENTRYPOINT ["dumb-init", "--", "/entrypoint.sh"]
 ---> Running in 5ede837acdd5
Removing intermediate container 5ede837acdd5
 ---> 44e2ebe1308c
Successfully built 44e2ebe1308c
googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

kminehart commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

bizmate commented 4 years ago

a PR with a more descriptive title would have been nice, but I am still wondering why this PR has not been merged. The Dockerfile is broken so any person trying to build this image must be having problems