fix: update bytes_sent and bytes_received to use Sum

GoogleCloudPlatform / cloud-sql-go-connector

A Go library for connecting securely to your Cloud SQL instances

Apache License 2.0

109 stars 29 forks source link

fix: update bytes_sent and bytes_received to use Sum #874

Closed jackwotherspoon closed 5 days ago

jackwotherspoon commented 2 weeks ago

Update bytes_sent and bytes_received metric views to use the Sum aggregation instead of LastValue.

godocs for Sum:

Sum indicates that data collected and aggregated with this method will be summed up. For example, accumulated request bytes can be aggregated by using Sum.

Ref: https://github.com/GoogleCloudPlatform/alloydb-go-connector/pull/624/

Thanks @nancynh for pointing this out 😄

enocom commented 2 weeks ago

LGTM. Sorry I missed this in the original PR.