search

GothenburgBitFactory / taskchampion-sync-server

The sync server for Taskchampion
MIT License
44 stars 8 forks source link

Read versions from .env file #17

Closed ogarcia closed 3 months ago

ogarcia commented 4 months ago

Instead of having to modify the environment variables separately in the pipelines (or in the Dockerfile) a .env file is used to declare them.

This solution adds an extra step to the pipeline but is more open than using GitHub environment variables.

ogarcia commented 4 months ago

This looks fine to me. I'm curious why not just put these values in the matrix:.. section (even if they are the same for each element of the matrix)?

Because if you notice those values are read from both workflows and the matrix is only for the build. 😉

If I put it only in the matrix we would have to change it later manually in the Dockerfile or in the docker workflow.

djmitche commented 4 months ago

Oh, right, thanks!

ogarcia commented 4 months ago

Now that I've had some time I've put some documentation in the Readme that partially solves #14.

djmitche commented 3 months ago

Sorry, I don't know why I didn't merge this before.

ogarcia commented 3 months ago

Sorry, I don't know why I didn't merge this before.

No problems. :wink:

What you should check is if the package that is generated is public because I personally do not see it. I seem to remember that you commented that you had modified the permissions but maybe it was not applied correctly.

djmitche commented 3 months ago

Interesting -- I can download it while logged in, but not in a private-browsing window. I think it was @tbabej who modified the permissions. I don't see any such permissions at the project level, so perhaps it's an org-level permission?

ogarcia commented 3 months ago

@djmitche if you go to packages, you will see the package in question and on the right hand side you will see that there is a link that says Package settings, if you enter and go to the bottom (in the Danger zone) you will see that the first option is to change the visibility of the package. It will be in private, just change it to public and that would be ready...

djmitche commented 3 months ago

Ah, thanks. I am not an org admin, so I can't do that. Perhaps @tbabej or @lauft can help?

tbabej commented 3 months ago

Looks like when this feature was introduced to Github, the default setting was to not allow public visibility. I changed that, now the org supports public visibility for any of the packages, so changing the settings should work going forward :+1: I already did it for this repo.