Grasscutters / Cultivation

A custom launcher designed to make it as easy as possible to proxy anime game traffic to private servers.
Apache License 2.0
968 stars 160 forks source link

Refactor cultivation to use solid-js and add a bunch of QoL changes #108

Closed Drevoed closed 1 year ago

Drevoed commented 1 year ago

WIP!!!

This PR is mainly a mashup of all the things I could find that could have an improve. I will write a detailed list later.

For now here are the core changes:

Not yet implemented but kept in mind:

This should obviously be 2.0 release, if it will ever be merged.

nitrog0d commented 1 year ago

kanye east

Arikatsu commented 1 year ago

Kanye north

SpikeHD commented 1 year ago

This is... SO many changes man. I have to ask that you split this up because this is wayyyyyy too much to review at once.

Drevoed commented 1 year ago

Yeah, sure, I'll cherry pick the features one by one into separate branches, so merging would be easier

Drevoed commented 1 year ago

Maybe also makes sense to create a next or dev as a main branch for that?

cc @SpikeHD

Drevoed commented 1 year ago

The thing is, changing architecture pr by pr will be relatively slow and painful, but I can make it work, yeah

SpikeHD commented 1 year ago

Sure, I'll make a new branch ("dev") you can target in future PRs