search

Grasscutters / Cultivation

A custom launcher designed to make it as easy as possible to proxy anime game traffic to private servers.
Apache License 2.0
953 stars 159 forks source link

Final pull request for set game path notification #177

Closed wehigami closed 1 year ago

wehigami commented 1 year ago

Whenever the game path is not set, a notification shows up that reminds you to do that. Hopefully there won't be conflicts anymore.

SpikeHD commented 1 year ago

I don't have a chance to test this at the moment, but this seems like it will notify every time the launcher is reopened, correct? Even if they have changed it in a previous session? It also disregards whether the default path is actually already correct or not (since the default path that is set upon first install is the default install for most people)

wehigami commented 1 year ago

I don't have a chance to test this at the moment, but this seems like it will notify every time the launcher is reopened, correct? Even if they have changed it in a previous session? It also disregards whether the default path is actually already correct or not (since the default path that is set upon first install is the default install for most people)

Nope, from my tests it will not notify every time you open the launcher and it also does not disregard the default path. If there's no path, it notifies.

NotThorny commented 1 year ago

Works as described, but since the default path is set for every user, the only time this will notify is if the user manually removes their current path in settings. Would be nice if it checked default path existing, like Spike said above, and then also notifies in that case. The average user with a different install will see the game is "set" even though the actual exe doesn't exist for them there, and still not know why the game isn't launching. They aren't seeing the notification since they have a game path set, just not a valid one.

Might also be a good idea to replace the span text with a tr so that other languages can have the right message there.

wehigami commented 1 year ago

@NotThorny Oh, I didn't understand what spike meant. This seems like a great idea. Also I wouldn't even have that such a solution may exist. Thank you!

NotThorny commented 1 year ago

Sure thing, just updated it to work properly since I hadn't actually tested it when writing it the first time. So if the default path doesn't exist for the user, it will unset the game path and alert that one needs to be set.

wehigami commented 1 year ago

@NotThorny Do I just push the change or create a new request?

NotThorny commented 1 year ago

@NotThorny Do I just push the change or create a new request?

You can just commit the suggested changes in this branch/PR, no need to make a new one

wehigami commented 1 year ago

Commited the changes, I think this should be working now

SpikeHD commented 1 year ago

Prettier checks fail, mind running that and committing the changes pls?