Grasscutters / Cultivation

A custom launcher designed to make it as easy as possible to proxy anime game traffic to private servers.
Apache License 2.0
974 stars 160 forks source link

Client Patching (for 2.8 release) #22

Closed 4Benj closed 2 years ago

4Benj commented 2 years ago

~~This was developed during the beta and has not yet been tested for the preload (Still waiting to finish the download lol). I recommend making a new branch for this for a bit of clean up.~~ This has been verified as working with the preload.

If you patch your game using the proxy make sure you uncheck "Connect via Grasscutter" and start the game to restore your game to an unpatched state before using the official launcher and connecting to official servers. Use at your own risk

A major bug I've noticed:

MoonLGH commented 2 years ago

okay lets start with, why version is still on 1.0.1

4Benj commented 2 years ago

okay lets start with, why version is still on 1.0.1

I actually got this working a couple days ago and I just forgot to update to the latest commit before uploading here to GitHub. The PR is still a draft for a couple reasons, one of them being that I haven't updated it to the latest commit of cultivation (although I doubt there would be any major issues)

SpikeHD commented 2 years ago

Oh, yeah, one final thing I meant to mention, Cultivation should always replace the patched metadata with the original upon closing the game, in the case of people who still use the official launcher to play the official game.

Should be a trivial addition, you can see where Culti does this by taking a look at src-tauri/src/main.rs, where you should just be able to pop a function call or two in there (and yes, I know what exists is a lil bit of a scuffed solution but I intend to improve it sometime in the future)

KingRainbow44 commented 2 years ago

Patching takes too long and the proxy starts up before the game launches

any status update on this? to me it sounds like we might need to rewrite the game watcher

SpikeHD commented 2 years ago

Patching takes too long and the proxy starts up before the game launches

any status update on this? to me it sounds like we might need to rewrite the game watcher

Trust me I already planned to, just hasn’t needed to be a priority yet. The problem is weird tho because all metadata related function calls are awaited before the proxy and game are even meant to start so idrk whats up with it.

4Benj commented 2 years ago

The problem is weird tho because all metadata related function calls are awaited before the proxy and game are even meant to start so idrk whats up with it.

Maybe I can do stuff with Promises as a temporary fix? awaits rarely seem to work properly for me in js lol.

4Benj commented 2 years ago

Closing since this is being merged into a special patch branch