search

Grasscutters / Cultivation

A custom launcher designed to make it as easy as possible to proxy anime game traffic to private servers.
Apache License 2.0
993 stars 165 forks source link

Disable CSP errors while loading js files from themes #54

Closed TotallyNotOndre closed 2 years ago

TotallyNotOndre commented 2 years ago

Disables CSP errors while loading themes js files Before: image

After: image

Seeker14491 commented 2 years ago

As I mentioned in Discord, allowing JavaScript in themes is not safe, at least in the current implementation. We should probably fix that before landing this fix.

KingRainbow44 commented 2 years ago

While yes, JS in themes isn't the safest idea, if you have some common sense and read the theme's source code before installing, its a nice thing for theme creators to use.

Seeker14491 commented 2 years ago

Most Cultivation users aren't coders who can read JS, so it's not reasonable to ask them to read themes' source code. I agree JS is useful for themes though.