Fix downloads' "visual bug". Aka files showing `extracting` even after being extracted

Grasscutters / Cultivation

A custom launcher designed to make it as easy as possible to proxy anime game traffic to private servers.

Apache License 2.0

968 stars 160 forks source link

Fix downloads' "visual bug". Aka files showing `extracting` even after being extracted #73

Closed Arikatsu closed 2 years ago

Arikatsu commented 2 years ago

it didnt work before cuz zipfile in the backend was a string and the payload that unzip.rs returned was an object. works perfectly fine now.

This was the visual bug

Logging the values before:

You can see the extract_end event was not logged.

After:

It perfectly logged.

SpikeHD commented 2 years ago

Missed this and implemented the exact same change LMFAO. Appreciate this all the same though <3

Arikatsu commented 2 years ago