[L] Improving, debugging MVP2 lenses for MVP3

[aalonsolopez]

TY!

[joofio]

following this discussion: https://github.com/orgs/Gravitate-Health/discussions/7

[aalonsolopez]

I transfer this issue to the repo that currently has the lenses :)

[aalonsolopez]

@joofio maybe I'm having a concept error, and kinda looks basic but... This is all the info that the IPS have. Where are supposed to be the codes related to each condition that the patient has?

https://gravitate-health.lst.tfo.upm.es/ips/api/fhir/Patient/pedro-patient

[joofio]

this is not the ips. that is the patient resource.

check IPS here: https://gravitate-health.lst.tfo.upm.es/ips/api/fhir/Patient/$summary?identifier=ips-2 or for pedro: https://gravitate-health.lst.tfo.upm.es/ips/api/fhir/Patient/$summary?identifier=Pedro-1

The list of IPSs we have: https://build.fhir.org/ig/hl7-eu/gravitate-health-ips/artifacts.html

[aalonsolopez]

as I said, a concept error by my side 👍🏻 thanks joao

[aalonsolopez]

Condition Lens finished - you can see the code here and it's connected meanwhile I'm thinking a way to make it more human readable. Eventually, we will create a "development library" to have all the logic that is repeated across lenses out of them. You can of course give feedback @joofio. Should I deploy it to dev?

[joofio]

yes it is better to deploy so i can test properly.

[aalonsolopez]

deployed :D

[joofio]

the allergy, intolerance, should be similar...

[aalonsolopez]

Almost the same but looking for intolerance instead of conditions yep

[aalonsolopez]

@joofio have you tried the lens? Is this what you expect?

[aalonsolopez]

A quick update: Pedro has no Allergy nor Intolerance.

[joofio]

try Helen https://build.fhir.org/ig/hl7-eu/gravitate-health-ips/Bundle-gravitate-helen.html will test the other now

[joofio]

@joofio have you tried the lens? Is this what you expect?

link to do it? like name of the lens?

[aalonsolopez]

@joofio have you tried the lens? Is this what you expect?

link to do it? like name of the lens?

lens-selector-mvp2_conditions

[aalonsolopez]

Should we unify Allergy and Intolerance lenses? In FHIR it's the same kind of resource....

[joofio]

yes merge them

[aalonsolopez]

okay!

Edit: OMG I said typo instead of kind. Mondays are hard

[joofio]

should this work ?

### condition lens
POST https://gravitate-health.lst.tfo.upm.es/focusing/focus/bundlepackageleaflet-es-94a96e39cfdcd8b378d12dd4063065f9?preprocessors=preprocessing-service-manual&lenses=lens-selector-mvp2_conditions&patientIdentifier=alicia-1

getting 500

[aalonsolopez]

let me check why is this happening

[aalonsolopez]

In 5 mins it's fixed

[aalonsolopez]

Fixed

[joofio]

can we send a preprocessed epi?instead or raw

[aalonsolopez]

Of course, the preprocessor manual ignores the ePI if its preprocessed

[joofio]

doesnt seem to be doing that.uploaded a test so you can try. https://github.com/hl7-eu/gravitate-health/blob/2c9cb410cbe69a2031aad191c76648d82be22e30/tests/lenses.http#L12

[joofio]

or did you mean a identifier for a preprocessed? and not the epi?

[aalonsolopez]

But there are no codes that Alicia and the preprocessed biktarvy shares, right? Or I'm wrong?

[joofio]

with the preprocessed in the folder, they do. that why i wanted to send a preprocessed epi

[aalonsolopez]

Ah! You mean in the body?

[joofio]

Ah! You mean in the body?

yes

[aalonsolopez]

Then the request you are trying is wrong. It's POST https://gravitate-health.lst.tfo.upm.es/focusing/focus/?preprocessors=preprocessing-service-manual&lenses=lens-selector-mvp2_conditions&patientIdentifier=alicia-1 and the example epi in the body like this

{
    "epi": <full ePI JSON>"
}

[aalonsolopez]

BTW, it doesn't work this way neither because it tries to preprocess it again. I will have to take a look at the Focusing Manager

[joofio]

yeah it doesnt work like this. let me change the preprocessed one on the server to test

[aalonsolopez]

I'm 100% sure that this is due to the change we made to display the errors during the process on the headers in the response. With a quick change it should work because that way is meant to work. (if preprocessed on body, ignore preprocessor)

[joofio]

ok please check that if you can. having he possibility of sending epi data will help testing

[aalonsolopez]

I will write here when I have it working 👍🏻

[aalonsolopez]

Try now :) @joofio

[aalonsolopez]

Also, I discovered that the "Accept": text/html was not working and it's also fixed

[joofio]

Also, I discovered that the "Accept": text/html was not working and it's also fixed

doesnt seem like it . with content-type: application/jsonreturns the html.

EDIT: it is working

POST https://gravitate-health.lst.tfo.upm.es/focusing/focus/?preprocessors=preprocessing-service-manual&lenses=lens-selector-mvp2_conditions&patientIdentifier=alicia-1
content-type: application/json
Accept: application/json

[aalonsolopez]

Nice!

[joofio]

let me do more testing with other codes to check the full compliance. but its looking good

EDIT:

the system changes and the highlight still applies. the match should be code+system

if you think it can take some time, I would prefer to solve this after all the other lenses.

cc @aalonsolopez (made edit, not sure you get the notification)

[aalonsolopez]

meanwhile, by the end of this week, I expect to have all the other lenses working too

[aalonsolopez]

let me do more testing with other codes to check the full compliance. but its looking good

EDIT:

the system changes and the highlight still applies. the match should be code+system

if you think it can take some time, I would prefer to solve this after all the other lenses.

cc @aalonsolopez (made edit, not sure you get the notification)

I think I understand it

[aalonsolopez]

https://github.com/Gravitate-Health/lens-selector-mvp2/commit/e1a9e118356866318568b346bd295e7d7d02801c

Now you can try. I think it's what you want right?

[joofio]

i tested and didnt work...

[aalonsolopez]

okay I forgot to test a thing. let me fix it fast

[aalonsolopez]

Sorry, now it works (I've tested myself). Try changing the system. IDK why the automatic deploy is not working properly.

[joofio]

now it works!

[aalonsolopez]

Go for the next lenses