GravityKit / GravityView

The best and easiest way to display Gravity Forms entries on your website.
https://www.gravitykit.com/products/gravityview/
245 stars 63 forks source link

Required validation doesn't apply to Multi-File upload field after form modification #1815

Open rafaehlers opened 1 year ago

rafaehlers commented 1 year ago

As described by a user:

Way to reproduce :

  1. Create a form with a multi-file upload (don´t make it required yet);
  2. Submit an entry (no file uploaded);
  3. Set up a view for editing the entry;
  4. Edit the form and make the field required;
  5. Update the entry using GravityView's Edit Entry page; the update will be successful even though the field is required and empty.

I've tested this behavior for other fields, but as soon as they are changed to "required" on the form, the edit entry page also requires them. This only affects the Multi-File Upload fields.

Tested on GV 2.16.6 and GFs 2.6.9

rafaehlers commented 1 year ago

https://secure.helpscout.net/conversation/2149768430/46863

zackkatz commented 1 year ago

@rafaehlers Can you retest using GF 2.7.2.2 or later?

rafaehlers commented 1 year ago

Yes, still happening on GFs 2.7.2.

It seems like the form is cached.

Also related: https://github.com/gravityview/GravityView/issues/853

rafaehlers commented 2 weeks ago

This is still happening on GV 2.29 after these fixes: https://github.com/GravityKit/GravityView/issues/2086 and GF's 2.8.18

rafaehlers commented 1 week ago

https://secure.helpscout.net/conversation/2724660495/57755