Duplication & inserting between fields

[doekenorg]

This PR adresses #2019.

It add's a duplication button once you hover a field or widget. Clicking it will duplicate the field and copy over all the values and settings of the originating field. It will add the field directly under the field that is being duplicated.

Bonus: Insert fields between others

After building the previous feature, I figured it would be very powerful to be able to inject fields in a specific place.

[doekenorg]

@zackkatz could you check the unit tests changes I made. This fixes the tests 🤞 but I have no clue what is being tested here. Only thing I know is that the shortcode tag is missing which returns a WP_Error. I had this failing test locally for a while; but in CI it always worked.

[mrcasual]

@doekenorg, the reason why the test was passing in CI is because we use the latest (non-beta/alpha) WordPress Develop release, which was 6.4.3 until April 2. This commit, introduced in 6.5, broke things. Your fix looks good IMHO.

[doekenorg]

@mrcasual right, no semver for WordPress. Thanks for clarifying. I should keep a closer eye on WordPress releases with regards to possible breaking changes.

[mrcasual]

@doekenorg, are you able to make duplication work using keyboard when you tab through focusable inputs?

[doekenorg]

@mrcasual yeah possibly

[doekenorg]

@mrcasual done. I took some time to see if I could move the popup to that position; but jQuery UI does not have the appropriate hooks for that. So that's for the redesign.

[zackkatz]

• [x] Keyboard navigation for duplication doesn't work unless hovering over a field/widget (see loom)

@doekenorg Thanks for the PR! Can you please check out the video? Thanks 👍

[crbdev]

It appears to me that the "+" icon is slightly off center. Not sure if that's intentional or a screen size thing or something :) Just thought I would highlight it.

[doekenorg]

@crbdev Good eye! The icon needed to be offset half its with to the left to be centered. It is "text" and it is aligned in the center. So it starts from the center, making it slightly offset to the right :-D Fixed.