GravityKit / GravityView

The best and easiest way to display Gravity Forms entries on your website.
https://www.gravitykit.com/products/gravityview/
246 stars 62 forks source link

Feature/1921 layout builder #2164

Closed doekenorg closed 3 weeks ago

doekenorg commented 1 month ago

This PR addresses #1921.

I've taken a free interpretation of the designs in Figma, to keep progress up.

Currently it only focusses on Widgets.

💾 Build file (59fe66296).

Mwalek commented 1 month ago

While doing preliminary testing of this PR I encountered 2 issues.

Issue 1: Custom Content in Top Widget Row Disappears

Custom content added to the top widget row is lost unless paired with a different widget (e.g., the search widget).

Steps to Reproduce:

  1. Delete all rows in the top widget area.
  2. Create a custom row with 2 columns.
  3. Add the "Custom Content" widget to both columns and input content.
  4. Save the View.

After the page refreshes, the custom content disappears.

Issue 2: Unable to Add Rows Without Saving the View First

Let me know if you have any questions :)

Issue Summary

doekenorg commented 1 month ago

@Mwalek @crbdev This is officially ready for full testing. Please include the Layout Builder Template as well. You can find that on the Release Manager.

Casey, I'm tagging you to check if this is (at least good) enough for your demo on Oct 28th.

Mwalek commented 1 month ago

@doekenorg there is still an issue when clicking the "Add row" button under Entries Fields before saving the View. Additionally, you may want to use uppercase "Row" to match the "Add Field" button.

doekenorg commented 1 month ago

@Mwalek fixed those.

Mwalek commented 1 month ago

@doekenorg thanks, I confirmed the fixes!

crbdev commented 1 month ago

It appears that the "Go back" link is missing. When you go to the Single Entry page, there is no link to go back to the Multiple Entries page. @Mwalek Do you see this too?

Mwalek commented 1 month ago

@crbdev I can't reproduce with build 0a24db8. You can see my test here:

https://basecamp.try.gravitykit.com/collection/lorem-3/item/item-26/

Feel free to create your own tests and change plugin versions on the site.

crbdev commented 1 month ago

@Mwalek Can you test again with the latest build in release manager? 0a24db8c6

Mwalek commented 1 month ago

@crbdev that's the same build that I used, no? 🤔

crbdev commented 4 weeks ago

Oh yes. My bad 😬 Okay, I'll see if I can figure out why this is happening.