GravityKit / GravityView

The best and easiest way to display Gravity Forms entries on your website.
https://www.gravitykit.com/products/gravityview/
245 stars 62 forks source link

Gravity Forms 2.5 Theme CSS issue with File Upload action buttons on Edit Entry page and GF 2.9 #2208

Open rafaehlers opened 4 hours ago

rafaehlers commented 4 hours ago

This issue only affects the Edit Entry page when Gravity Forms 2.9.x is used and when the "Default Form Theme" setting is set to Gravity Forms 2.5 Theme.

image

https://github.com/user-attachments/assets/4493db67-18d1-4dba-8819-877f0174bbb1

This seems to be related to the fact that the Edit Entry page is loading two Gravity Forms stylesheets: basic.min.css and admin-icons.min.css

https://29beta.try.gravitykit.com/wp-content/plugins/gravityforms/assets/css/dist/basic.min.css?ver=2.9.0 https://29beta.try.gravitykit.com/wp-content/plugins/gravityforms/assets/css/dist/admin-icons.min.css?ver=2.9.0

Both stylesheets set font-family for the .gform-icon class, and the font-family: gform-icons-theme!important set for basic.min.css is the problem.

Gravity Forms 2.8.x, loads the admin-icons.min.css stylesheet later, so the icons are showing up correctly:

image

Perhaps this is related to the load order of the stylesheets since both of them are loaded on the Edit Entry page.

Link to check: https://29beta.try.gravitykit.com/view/file-upload/ (log-in as admin)

rafaehlers commented 4 hours ago

https://secure.helpscout.net/conversation/2759683429/58860