Search not using exact-match for select fields

[zackkatz]

Search for urology and in addition to results related to urology we are getting neurology as well. https://secure.helpscout.net/conversation/285290817/0/

The following fields should use exact-match, not "contains":

• [x] Select
• [ ] Radio
• [ ] Checkbox
• [ ] Multiselect

Update: Select fields work as expected.

[soulseekah]

Possibly related: #821

[zackkatz]

This works for me. Closing until needed.

[zackkatz]

@soulseekah I was able to reproduce with Multi Select.

• Create Multi Select field with two choices:
  • Eurology
  • Neurology
• Submit combinations of both, one, or the other
• Create View
• Update Search Bar to search that multi select field
  • Set it to "Select" input
• go to View, filter by "Eurology"

[soulseekah]

GFQuery does not know how to search within JSON fields it seems.

GF_Query_JSON_Literal is detected but %urology% is not converted to %"urology"% for exact matching. Wrapping the term with " signs produces a lot of \\\\" that don't match what we need when escaped.

I think we need to somehow override these JSON-based multifields in the query and add them as quoted searches.

[soulseekah]

Something like this works, but I don't like it at the moment. I want to give it some more thought.

[soulseekah]

We also need figure out how to make the "is" and "contains" operators work for JSON-based multifields.

I'm assuming "is" has to match the selection exactly, so ["one","two"] is NOT "one", but is ["one","two"]. "contains" matches a partial ["one","two"] contains "one".

This is only for select, multiselect, dropdown, radio search controls. Text search is always inexact, unless quoted, I think. Searching for "urology" will only give out "urology" not "neurology".

Still investigating.

[soulseekah]

https://secure.helpscout.net/conversation/1010775016/23477?folderId=408735

[soulseekah]

https://github.com/gravityview/DataTables/issues/122

[zackkatz]

@soulseekah What feedback do you need for this?

[soulseekah]

Quoting from above:

we also need figure out how to make the "is" and "contains" operators work for JSON-based multifields.

I'm assuming "is" has to match the selection exactly, so ["one","two"] is NOT "one", but is ["one","two"]. "contains" matches a partial ["one","two"] contains "one".

This is only for select, multiselect, dropdown, radio search controls. Text search is always inexact, unless quoted, I think. Searching for "urology" will only give out "urology" not "neurology".

[zackkatz]

Yep that sounds good, @soulseekah

[soulseekah]

I'm even thinking that this is a Gravity Forms issue actually. And that it has to be patched inside GF_Query instead.

[zackkatz]

This is still happening.

[zackkatz]

Multiselect inputs are deprecated in Gravity Forms; they show an accessibility notice when using the field…this is less of a problem as it's being used less.

[zackkatz]

Example issues:

• GF Checkbox field => GV Checkbox search input works.
• GF Checkbox field => GV Select search input does not work.