cid assignment fails whenever players with same name are in a game together

GraylinKim / sc2reader

A python library that extracts data from various Starcraft II resources to power tools and services for the SC2 community. Who doesn't want to hack on the games they play?

http://sc2reader.readthedocs.org

MIT License

413 stars 85 forks source link

cid assignment fails whenever players with same name are in a game together #138

Closed dsjoerg closed 11 years ago

dsjoerg commented 11 years ago

Not sure if this can be rectified before https://github.com/Blizzard/s2protocol/issues/8 is fixed, but https://github.com/GraylinKim/sc2reader/blob/master/sc2reader/resources.py#L431

appears to be correct only if each player has a unique name.

For example in this replay: http://ggtracker.com/matches/3604592/replay in which both players have the same name,

ggtracker processing fails because it requires that every player have a cid in order to use the tracker-events data.

GraylinKim commented 11 years ago

Uh, wow. I didn't realize that two people could have the same name. That changes things.

I can probably accommodate duplicate player names names. Adding this to 0.5.2.

GraylinKim commented 11 years ago

Resolved by 1356f25d640c8422d386b01378b1c9a810e8453b