search

GraylinKim / sc2reader

A python library that extracts data from various Starcraft II resources to power tools and services for the SC2 community. Who doesn't want to hack on the games they play?
http://sc2reader.readthedocs.org
MIT License
413 stars 85 forks source link

Creep Tracker #139

Closed jonomon closed 11 years ago

jonomon commented 11 years ago

Added Creep Spread tracker to replay.py Added seconds to tracker events

(I hope I did this correctly)

GraylinKim commented 11 years ago

Thanks for the pull request Jonathan. I'm going to leave this to @dsjoerg until he gives it the okay.

Instead, I'm going to suggest that instead of making your commits on master you create a new feature branch (creep-tracker-clustering) and commit there. That way you can track as many alternate implementations as necessary (creep-tracker-grid) or start work on a new feature (e.g. vision-tracker) without getting the commits mixed up. Any new commits on a branch are automatically added to the pull request for that branch so if you don't use feature branches new commits can unintentionally be added to an existing pull request.

I know you were going to clean the code up, but I'll just point out that before I accept any pull request you'll need to clean up inconsistent white space and remove all trailing spaces.

GraylinKim commented 11 years ago

Closing this request. You can open a new one from your creep tracking branch when it is ready.