GraylinKim / sc2reader

A python library that extracts data from various Starcraft II resources to power tools and services for the SC2 community. Who doesn't want to hack on the games they play?
http://sc2reader.readthedocs.org
MIT License
413 stars 85 forks source link

Issues with Mec +1 attack and Mec +1 defense #166

Closed gmercey closed 9 years ago

gmercey commented 10 years ago

Hello,

I try to parse different replays and I can't parse replays with Mec +1attack/defense. I make some tests with and without those elements and I always have the same results.

Did anyone reproduce the bug ?

GraylinKim commented 10 years ago

Can you share a replay that demonstrates this? If I can reproduce I will fix.

gmercey commented 10 years ago

Here a replay https://dl.dropboxusercontent.com/u/16532876/Mech%20opener%20TvP%203.SC2Replay

dsjoerg commented 10 years ago

Can you show the error message you're getting, and what version of sc2reader you're using?

For fun I uploaded the replay to GGTracker (which uses an older version of sc2reader) and it seems to parse OK: http://ggtracker.com/matches/4644354

gmercey commented 10 years ago

Sorry I not home, I don't have the error message, but I'm using the last version of the master branch.

GraylinKim commented 9 years ago

Closing this. Issue no longer presents with current codebase.