search

GraylinKim / sc2reader

A python library that extracts data from various Starcraft II resources to power tools and services for the SC2 community. Who doesn't want to hack on the games they play?
http://sc2reader.readthedocs.org
MIT License
411 stars 85 forks source link

Fixes SelectionTracker plugin with new handler names. #169

Closed EHadoux closed 10 years ago

GraylinKim commented 10 years ago

Thanks for the patch. Can you add a test that demonstrates the problem and that it is fixed?

EHadoux commented 10 years ago

How can I demonstrate the problem with the modified version of the plugin? It's just a renaming of the handler according to the "new" name of the generated events. By the way, what is the difference between engine plugins (this one for instance) and factory plugins. Do I have to change there too?

EHadoux commented 10 years ago

Bump. This issue is related to #167 and therefore to a303fd74db70d5ba4960836b83daf7197b8db047. PS: sorry for the double post, I thought there was a bug in my code after posting.

GraylinKim commented 10 years ago

Don't worry about the tests. Basically, you'd find a replay that produced incorrect selection values for a particular time frame because the handlers weren't being called to demonstrate the issue that was fixed.

Factory plugins are old style plugins that literally just accepted a replay and returned a replay as a single call function. Factory plugins are deprecated and don't use the event system, you shouldn't need to mirror these changes in that code.

EHadoux commented 10 years ago

OK, thank you very much :) I'll carry on submitting more plugins if that's ok for you.

GraylinKim commented 10 years ago

Yeah, that's fine with me.