GraylinKim / sc2reader

A python library that extracts data from various Starcraft II resources to power tools and services for the SC2 community. Who doesn't want to hack on the games they play?
http://sc2reader.readthedocs.org
MIT License
411 stars 85 forks source link

Parsing error while opening with sc2 program #175

Closed mehdi-kaytoue closed 9 years ago

mehdi-kaytoue commented 10 years ago

I can't open the following replay with sc2reader (see error below) while I can open it and watch it as a replay with sc2.

Any idea?

http://sc2rep.replays.net/sites/all/modules/pubdlcnt/pubdlcnt.php?file=/files/sc2rep/qxc_vs_HerO 3.sc2replay&nid=2300

Code: r = SC2Factory().load_replay(filename, load_level = 2)

Error:

r = SC2Factory().load_replay(filename, load_level = 2) File "build\bdist.win-amd64\egg\sc2reader\factories\sc2factory.py", line 85, in load_replay File "build\bdist.win-amd64\egg\sc2reader\factories\sc2factory.py", line 137, in load File "build\bdist.win-amd64\egg\sc2reader\factories\sc2factory.py", line 146, in _load File "build\bdist.win-amd64\egg\sc2reader\resources.py", line 246, in init sc2reader.exceptions.MPQError: (u'Unable to construct the MPQArchive', ValueError('Invalid file header.',))

dsjoerg commented 10 years ago

It's a Wings of Liberty game from over 2 years ago. Uploaded it to here: http://ggtracker.com/matches/5269463. So it is parseable, and since ggtracker uses sc2reader I expect sc2reader can handle it too, and the problem must be something else.

Can you give the exact and full code you're running? in your example you don't show what filename was set to. Did you set it to the URL, or did you download the file to your local system, and in that case what filename did you give?

The URL you supplied in your message wasn't right, I had to change it to http://sc2rep.replays.net/sites/all/modules/pubdlcnt/pubdlcnt.php?file=/files/sc2rep/qxc_vs_HerO%203.sc2replay&nid=2300 and then I could download it. Alternatively you could use this URL now: http://ggtracker.com/matches/5269463/replay

—David

On Sun, Jul 27, 2014 at 2:02 PM, mehdi-kaytoue notifications@github.com wrote:

I can't open the following replay with sc2reader (see error below) while I cant open it and watch it as a replay with sc2.

http://sc2rep.replays.net/sites/all/modules/pubdlcnt/pubdlcnt.php?file=/files/sc2rep/qxc_vs_HerO 3.sc2replay&nid=2300

Code: r = SC2Factory().load_replay(filename, load_level = 2) Error:

r = SC2Factory().load_replay(filename, load_level = 2) File "build\bdist.win-amd64\egg\sc2reader\factories\sc2factory.py", line 85, in load_replay File "build\bdist.win-amd64\egg\sc2reader\factories\sc2factory.py", line 137, in load File "build\bdist.win-amd64\egg\sc2reader\factories\sc2factory.py", line 146, in _load File "build\bdist.win-amd64\egg\sc2reader\resources.py", line 246, in init sc2reader.exceptions.MPQError: (u'Unable to construct the MPQArchive', ValueError('Invalid file header.',))

— Reply to this email directly or view it on GitHub https://github.com/GraylinKim/sc2reader/issues/175.

mehdi-kaytoue commented 10 years ago

Thanks David for your reply. The url is valid, and actually in interactive python I can open the replay, my bad. It is clearly another problem, I will investigate that.

By the way, do you specify somewhere what are the website ggtracker does scrap? From what I understand, it is useless for me to track http://sc2rep.replays.net since I also use the GGTracker API to get replays.

Cheers, Mehdi

dsjoerg commented 10 years ago

ggtracker doesn't scrape any websites for replays!

On Mon, Jul 28, 2014 at 3:26 AM, mehdi-kaytoue notifications@github.com wrote:

Thanks David for your reply. The url is valid, and actually in interactive python I can open the replay, my bad. It is clearly another problem, I will investigate that.

By the way, do you specify somewhere what are the website ggtracker does scrap? From what I understand, it is useless for me to track http://sc2rep.replays.net since I also use the GGTracker API to get replays.

Cheers, Mehdi

— Reply to this email directly or view it on GitHub https://github.com/GraylinKim/sc2reader/issues/175#issuecomment-50307398 .

GraylinKim commented 9 years ago

Closing. It seems like the author's issue was resolved a while ago, as mentioned, the linked replay parses just fine.