search

GraylinKim / sc2reader

A python library that extracts data from various Starcraft II resources to power tools and services for the SC2 community. Who doesn't want to hack on the games they play?
http://sc2reader.readthedocs.org
MIT License
411 stars 85 forks source link

Merging the different repositories #178

Closed EHadoux closed 3 years ago

EHadoux commented 9 years ago

Hi,

Is it possible for you to merge in this repository all the stuffs that have been done in the different branches of i.e. ggtracker/sc2reader. As there are some commits ahead and some behind this master, I'm not quite sure what to do. Moreover, it would be better, imho, to merge all the plugins in one repo, instead of having some here, some in ggtracker's and some in mine.

Cheers,

Emmanuel

dsjoerg commented 9 years ago

Hi Emmanuel, not sure who you are asking to do this, but the beauty of open source is that whoever wants it can do it!

It is on my to-do list to integrate with the main line of sc2reader but there are some other things ahead of it on the list :\

EHadoux commented 9 years ago

Hi David,

I actually don't know who is in charge in here as @GraylinKim seems really busy. In fact, I was hoping that each person having a piece of code to include creates a pull-request in order to have this repo completely self-contained (and not this + a merge of yours + a merge of mine + a merge of etc...) I have some pull-requests left to propose but as they lay on the one that is not yet included, it would be a mess if they weren't merged in the good sequence. Moreover, for the supply plugin, as it is not merged in this master, we were not completely sure it is usable and accurate so we had to develop our own -> inefficient process. Probably the same for the creep spread plugin. I'll feel bad if this repo die as there is a last extension, I want to keep it alive but I am not able to manage the low-level stuffs on the replay files.

Cheers!

nibalizer commented 9 years ago

+1 for consolidating