decoding upgrade_type_name so that it reads as a string not bytes in python 3

GraylinKim / sc2reader

A python library that extracts data from various Starcraft II resources to power tools and services for the SC2 community. Who doesn't want to hack on the games they play?

http://sc2reader.readthedocs.org

MIT License

411 stars 85 forks source link

decoding upgrade_type_name so that it reads as a string not bytes in python 3 #183

Closed StoicLoofah closed 9 years ago

StoicLoofah commented 9 years ago

It looks like the rest of these event types do this conversion, and it was just an oversight. I ran into an issue with this in spawningtool where I had to convert things on my side to get it to work.

coveralls commented 9 years ago

Coverage decreased (-0.03%) to 76.21% when pulling c5d22d68ba802f36068ed7199cc157ee0521819b on StoicLoofah:decode_upgrade_type_name into 722ae4f16430c023bafa32fa69a1773909b1f867 on GraylinKim:master.

coveralls commented 9 years ago

Coverage remained the same at 76.24% when pulling c5d22d68ba802f36068ed7199cc157ee0521819b on StoicLoofah:decode_upgrade_type_name into 722ae4f16430c023bafa32fa69a1773909b1f867 on GraylinKim:master.

StoicLoofah commented 9 years ago

Sorry to press here @GraylinKim @dsjoerg , but would it be possible to get this merged in? This is blocker for me to get spawningtool.git up to python3, which subsequently blocks the spawning tool website from updating. I can of course run off of my fork, but I would prefer to stay pointed at this if possible