search

GraylinKim / sc2reader

A python library that extracts data from various Starcraft II resources to power tools and services for the SC2 community. Who doesn't want to hack on the games they play?
http://sc2reader.readthedocs.org
MIT License
411 stars 85 forks source link

New s2protocol #193

Open cjb opened 7 years ago

cjb commented 7 years ago

Hi, I haven't contributed before, but I see that Spawning Tool's failing to parse new replays and there's a new s2protocol released six days ago:

https://github.com/Blizzard/s2protocol/commit/d62b17cd12790c5a96164757b7731100ee8596e2

StoicLoofah commented 7 years ago

@dsjoerg looks like you already tackled this with your last 3 commits on https://github.com/ggtracker/sc2reader ?

As a general point, I guess it seems that this repo isn't really being maintained, where both ggtracker and spawningtool both maintain forks. should we centralize and have a new official sc2reader repo?

dsjoerg commented 7 years ago

@StoicLoofah fine by me, I can give you push rights to https://github.com/ggtracker/sc2reader or I can switch to using a new one if you prefer.

StoicLoofah commented 7 years ago

I'm down to use the ggtracker branch: it's almost certainly the best maintained. I myself am too lazy to write tests 😛

@GraylinKim can you assign @dsjoerg as the owner of sc2reader on pypi so we can start pushing official releases there again?

EHadoux commented 7 years ago

Oh yes, please do that. It was starting to get difficult to untangle everything and to know where to look for and merge. (Although it has been quite some time since the last time)