search

GraylinKim / sc2reader

A python library that extracts data from various Starcraft II resources to power tools and services for the SC2 community. Who doesn't want to hack on the games they play?
http://sc2reader.readthedocs.org
MIT License
413 stars 85 forks source link

s2gs parsing trouble with unknown data structures 22, 24, 26, 28 #66

Closed dsjoerg closed 12 years ago

dsjoerg commented 12 years ago

the s2gs hashes are private, will send them in separate message.

GraylinKim commented 12 years ago

All these s2gs parsing problems should be fixed at this point. Reopen if you disagree.

dsjoerg commented 12 years ago

That word "should" scares me. Did you try parsing the s2gs files corresponding to the hashes I sent when this issue was opened?

GraylinKim commented 12 years ago

Sorry, I should be more affirmative with my language!

Anyway, I went back over all the s2gs files on my possession and confirmed the fix. I also found and fixed a couple weird issues with settings in s2gs files for custom maps in 32297cef0b16e1dd92c82927a4c590ece51f2660 and 92ed8289bfb2a570f6e6f89dba4200aa286c6603. I also confirmed that all your integration tests passed before and after the changes. s2gs should be good to go!

dsjoerg commented 12 years ago

BOOM

dsjoerg commented 12 years ago

Ha, you managed to sneak a "should" in the beginning and the end of your "affirmative" language. You should be ashamed!