search

GraylinKim / sc2reader

A python library that extracts data from various Starcraft II resources to power tools and services for the SC2 community. Who doesn't want to hack on the games they play?
http://sc2reader.readthedocs.org
MIT License
413 stars 85 forks source link

replay.date is wrong #71

Closed batrick closed 12 years ago

batrick commented 12 years ago

I ran the PrettyPrinter example on two different replays. Both give the same date in 1600:

$ python2 test.py 2011-05-17\ 01-10-24\ ZvZ\ batrick\ (Z)\ vs\ guitarizt\ (Z)\ The\ Shattered\ Temple.SC2Replay

2011-05-17 01-10-24 ZvZ batrick (Z) vs guitarizt (Z) The Shattered Temple.SC2Replay

SC2 Version 1.3.3.18574 Ladder Game, 1600-12-31 20:00:00 1v1 on Length: 20.50

Team 1: (Z) guitarizt

Team 2: (Z) batrick

$ python2 test.py Ulaan\ Deeps.SC2Replay

Ulaan Deeps.SC2Replay

SC2 Version 1.4.3.21029 Ladder Game, 1600-12-31 20:00:00 3v3 on Length: 17.03

Team 1: (Z) batrick (Z) irishGUARD (T) Fuzzzy

Team 2: (T) Lonely (P) silent (P) Devin

batrick commented 12 years ago

Also seems the map attribute is the empty string.

GraylinKim commented 12 years ago

You are going to need to link me to the replays for me to help here. Likely this issue has already been fixed in the v15 branch but I've not fixed up the scripts to work in that branch yet.

GraylinKim commented 12 years ago

I fixed the sc2printer script in the v15 branch. Please let me know if this problem persists.

batrick commented 12 years ago

v15 fixed this for me.

Do you still want the replays?

GraylinKim commented 12 years ago

Nah, no need. I'll be merging into master tonight so I'm closing this issue. Thanks for reporting @batrick.