search

GraylinKim / sc2reader

A python library that extracts data from various Starcraft II resources to power tools and services for the SC2 community. Who doesn't want to hack on the games they play?
http://sc2reader.readthedocs.org
MIT License
413 stars 85 forks source link

Cannot retrieve map name from s2gs for Megaton Team Monobattles #78

Open dsjoerg opened 11 years ago

dsjoerg commented 11 years ago 
>>> wget eu.depot.battle.net:1119/e777780e13cae31b39e0a30609c9272f539e172392339f2b992dcbe3de69823f.s2gs
>>> s2gsfile = open("e777780e13cae31b39e0a30609c9272f539e172392339f2b992dcbe3de69823f.s2gs", "rb")
>>> summary = sc2reader.load_game_summary(s2gsfile)
>>> summary.map_name
'Teams 04 (Mod)'

Within the SC2 client, the map name is shown as Megaton Team Monobattles. Perhaps this is unsolvable, but I thought it was worth a look.

GraylinKim commented 11 years ago

This is another localization issue. The map data wasn't translated into English so there was no 5th sheet with map information. Unfortunately the 'enGB' localization didn't have 'Megaton Team Monobattles' as the map name. It had 'TSL4 Antiga Shipyard'. So I'm rather confused on this one.

s2gs files aren't as relevant any more so I'm not going to look into it any further unless something changes..

dsjoerg commented 11 years ago

s2gs files are still relevant -- they will be a useful way of mass-gathering certain kinds of data. but much less urgent than they used to be.

GraylinKim commented 11 years ago

Putting this on indefinite hold. Eventually it will make sense to better deal with localization issues in sc2reader. We'll figure out how to handle this when that time comes.